[Upgrade] Go-Ethereum release v1.9.19 #1146

ricardolyn · 2021-03-01T11:44:30Z

AT tests won't pass until we don't merge Consensys/quorum-acceptance-tests#83

TODO

Plan & Analyse

Review the Release Notes
Review PRs in the section below

As you review, list extra changes and/or tests to be implemented to ensure compatibility with GoQuorum specific features.

Build & Test

Pull and checkout PR branch locally, then merge GoQuorum master into this branch
Resolve conflicts, taking into account the prior analysis
Implement required changes until all unit tests pass
Implement required changes until acceptance tests pass
Implement extra changes and/or tests
Implement required changes until lint passes
Verify any left TODOs in the code

Extra Changes & Tests

cmd, core, eth, light, trie: dump clean cache periodically ethereum/go-ethereum#20391 Journal argument: verify if journal string argument on NewDatabaseWithCache affects the behaviour for the private database. Moreover, this change is affecting AT as in the end of the test, after the cleanup of data, this file is writing which creates issues in the next test which assumes the folder is empty.
node: refactor package node ethereum/go-ethereum#21105 Big refactor: review carefully changes done by this if it affects tests on GoQuorum. for example, all values for HTTP are removed from node.go. node/service.go is removed. Documentation: https://gist.github.com/renaynay/5bec2de19fde66f4d04c535fd24f0775.
GraphQL changes: Note, if you were using GraphQL previously, it was moved to the HTTP RPC endpoint. The old --graphql.host and --graphql.port flags will not work any more. You might need to adjust your TOML config files accordingly too.. We need to mention this in the docs and in the release notes, what is the process to update those @nmvalera ?
node: refactor package node ethereum/go-ethereum#21105 startWSEndpoint removed from node/endpoints.go: we need to verify how is the new logic for the WS endpoint to make sure the listener is created with tlsConfigSource.
node: refactor package node ethereum/go-ethereum#21105 RegisterEthService return changed: now it returns the ethapi.Backend so we maybe don't need anymore the chan *eth.Ethereum which was used by raft service as it listens to this channel to get Ethereum backend
node: refactor package node ethereum/go-ethereum#21105 if ctx.GlobalString(utils.SyncModeFlag.Name) == "light" removed: when the syncMode was light, we were doing setContractAuthzProviderFunc = lesService.SetContractAuthorizationManager, but as now is not present anymore, we need to check if we still need to add that function somewhere else.
Improve the initialization code for the Lifecycle on the Quorum services to match the approach of https://gist.github.com/renaynay/5bec2de19fde66f4d04c535fd24f0775
miner: refactor helper functions in worker.go ethereum/go-ethereum#21044: Re-use helper function copyReceipts in the function commit() for the private receipts (miner/worker.go).
Q: should Node.getSecuritySupports() return pointers?

Go-Ethereum Release: Red Janey (v1.9.19)

Version: v1.9.19
Published: 2020-08-11T11:13:36Z

Release notes

Geth v1.9.19 is our regular biweekly maintenance release. Apart from the numerous bug-fixes however, it also ships a more deterministic transaction sort order during mining (FIFO). The goal is to reduce front-runner spam which abused miner randomness for transactions at the same price level.

Sort same-priced transactions by arrival time during mining to reduce front-running (#21358).
Persist the trie read cache on shutdown to speed up warmup time after a reboot (#20391).
Swap out the block fetcher of les/x to use the same mechanism as eth/6x (#20692).
Support setting custom HTTP headers on RCP clients e.g. for authentication (#21392).
Refactor node lifecycle management, merge GraphQL onto HTTP endpoint (#21105).
Print enode ID of a node too when doing an ENR dump via devp2p (#21270).
Trim the build paths to avoid leaking builder infos into the binaries (#21374).
Limit concurrent UPnP requests to avoid crashing certain routers (#21390).

Bugfixes:

Fix a potential data corruption by leaking out txpool internals into the miner (#21159).
Avoid a light server doing EVM calls during handshake while it's syncing (#21425).
Fix the trie clean cache size calculation if snapshots are disabled (#21416).
Revert an optimization regression in the JUMPDEST analysis (#21411).
Fix EIP 712 structured data signing corner cases (#21306, #21307).
Fix round-trip time calculation in the downloader (#21427, #21429).
Fix a panic in ethstats on the Görli stats page (#21404, #21434).
Fix a hang in the initial fast-sync's state sync phase (#21433).
Fix graceful LES server shutdown (#21426).

Note, if you were using GraphQL previously, it was moved to the HTTP RPC endpoint. The old --graphql.host and --graphql.port flags will not work any more. You might need to adjust your TOML config files accordingly too.

For a full rundown of the changes please consult the Geth 1.9.19 release milestone

As with all our previous releases, you can find the:

Pre-built binaries for all platforms on our downloads page.
Docker images published under ethereum/client-go.
Ubuntu packages in our Launchpad PPA repository.
OSX packages in our Homebrew Tap repository.

Codebase changes assessment

Legend

File Stats: (A) Added, (M) Modified and (R) Removed

Line Stats: (A) Added and (R) Removed

Assessment:

✅ No conflict expected
⚠ Review required to assess changes
‼️ Conflicts expected and review required

35 Pull Requests

🔍	Link	Title	File Stats M/A/R	Packages changed (files changed)	Line Stats A/R	Top 5 Changed Files (lines changed)
✅	#21379	`Fix posible nil exeption`	3/0/0	`cmd/clef/docs` (1) `cmd/faucet` (1) `signer/storage` (1)	5/5	`signer/storage/aes_gcm_storage.go` (12) `cmd/clef/docs/setup.md` (4) `cmd/faucet/faucet.html` (4)
⚠️	#20391	`cmd, core, eth, light, trie: dump clean cache periodically`	12/0/0	`eth` (4) `cmd/geth` (2) `core` (2) `core/state` (1) `light` (1) `trie` (1) `cmd/utils` (1)	128/24	`trie/database.go` (102) `eth/config.go` (56) `core/blockchain.go` (46) `cmd/utils/flags.go` (32) `eth/gen_config.go` (24)
✅	#20692	`les: implement new les fetcher`	22/1/0	`les` (10) `consensus/ethash` (3) `eth/fetcher` (3) `les/utils` (2) `consensus/clique` (2) `eth` (1) `cmd/geth` (1) `consensus` (1)	1325/1021	`les/fetcher.go` (2410) `eth/fetcher/block_fetcher_test.go` (592) `les/fetcher_test.go` (536) `eth/fetcher/block_fetcher.go` (412) `les/utils/expiredvalue_test.go` (154)
‼️	#21044	`miner: refactor helper functions in worker.go`	2/0/0	`consensus/clique` (1) `miner` (1)	52/41	`miner/worker.go` (176) `consensus/clique/clique.go` (10)
✅	#21382	`les: fix unittest`	1/0/0	`les` (1)	4/4	`les/fetcher_test.go` (16)
⚠️	#21378	`eth/downloader: remove eth62`	3/0/0	`eth/downloader` (3)	5/60	`eth/downloader/downloader_test.go` (80) `eth/downloader/peer.go` (42) `eth/downloader/downloader.go` (8)
⚠️	#21374	`build: use -trimpath flag when building executables`	1/0/0	`build` (1)	4/2	`build/ci.go` (12)
✅	#20878	`core/bloombits: use single channel for shutdown`	1/0/0	`core/bloombits` (1)	24/35	`core/bloombits/matcher.go` (118)
‼️	#21384	`rawdb: fix comments to godoc convention format`	1/0/0	`core/rawdb` (1)	2/2	`core/rawdb/freezer.go` (8)
⚠️	#21358	`core: sort txs at the same gas price by received time`	2/0/0	`core/types` (2)	86/22	`core/types/transaction.go` (110) `core/types/transaction_test.go` (106)
✅	#21391	`rpc: remove silly use of ReadVarint in subscription ID generator`	1/0/0	`rpc` (1)	6/3	`rpc/subscription.go` (18)
‼️	#21392	`rpc: add SetHeader method to Client`	3/0/0	`rpc` (3)	79/10	`rpc/client_test.go` (74) `rpc/http.go` (74) `rpc/client.go` (30)
✅	#21306	`TypedData.EncodeData should not reject a Domain without a ChainId`	2/0/0	`signer/core` (2)	9/5	`signer/core/signed_data_test.go` (16) `signer/core/signed_data.go` (12)
✅	#21105	`node: refactor package node`	30/0/0	`cmd/geth` (6) `les` (5) `cmd/utils` (3) `graphql` (2) `eth` (2) `miner` (2) `ethclient` (1) `cmd/wnode` (1) `cmd/p2psim` (1) `core/rawdb` (1) `internal/ethapi` (1) `cmd/faucet` (1) `console` (1) `ethstats` (1) `mobile` (1) `les/checkpointoracle` (1)	563/592	`ethstats/ethstats.go` (304) `cmd/utils/flags.go` (228) `graphql/graphql_test.go` (216) `eth/backend.go` (188) `miner/stress_ethash.go` (178)
✅	#21307	signer: EIP 712, parse `bytes` and `bytesX` as hex strings + correct padding	2/0/0	`signer/core` (2)	118/3	`signer/core/signed_data_internal_test.go` (188) `signer/core/signed_data.go` (54)
✅	#21270	`cmd/devp2p: print enode:// URL in enrdump`	1/0/0	`cmd/devp2p` (1)	14/5	`cmd/devp2p/enrcmd.go` (38)
⚠️	#21159	`core: avoid modification of accountSet cache in tx_pool`	1/0/0	`core` (1)	5/2	`core/tx_pool.go` (14)
⚠️	#21404	`ethstats: avoid concurrent write on websocket, fixes #21403`	1/0/0	`ethstats` (1)	57/11	`ethstats/ethstats.go` (136)
✅	#21390	`p2p/nat: limit UPNP request concurrency`	2/0/0	`p2p/nat` (2)	64/25	`p2p/nat/natupnp.go` (160) `p2p/nat/nat.go` (18)
‼️	#21095	`core: use errors.Is for consensus errors check`	1/0/0	`core` (1)	6/6	`core/blockchain.go` (24)
⚠️	#21383	`downloader: add eth65 tests`	1/0/0	`eth/downloader` (1)	62/20	`eth/downloader/downloader_test.go` (164)
‼️	#21414	`cmd/geth: fix import / export issues related to DB unavailability`	1/0/0	`cmd/geth` (1)	4/2	`cmd/geth/chaincmd.go` (12)
✅	#21411	`core/vm: avoid map lookups for accessing jumpdest analysis`	1/0/0	`core/vm` (1)	6/0	`core/vm/contract.go` (12)
‼️	#21415	`cmd/geth: fixes db unavailability for chain commands`	2/0/0	`cmd/geth` (2)	9/6	`cmd/geth/chaincmd.go` (26) `cmd/geth/config.go` (4)
⚠️	#21419	`core: Use maxQueuedTxAnns for to limit the number of transactions announced`	1/0/0	`eth` (1)	1/1	`eth/peer.go` (4)
‼️	#21416	`cmd/utils: grant snapshot cache to trie if disabled`	2/0/0	`cmd/utils` (1) `eth` (1)	3/2	`eth/config.go` (8) `cmd/utils/flags.go` (2)
✅	#21425	`les: update checktime even if check fails`	1/0/0	`les/checkpointoracle` (1)	5/3	`les/checkpointoracle/oracle.go` (16)
✅	#21427	`eth/downloader: save the correct delivery time for state sync`	1/0/0	`eth/downloader` (1)	10/9	`eth/downloader/statesync.go` (38)
⚠️	#21426	`les: close all connected les-server when shutdown`	3/0/0	`les` (3)	47/0	`les/peer.go` (78) `les/server.go` (10) `les/server_handler.go` (6)
✅	#21429	`eth/downloader: set deliverytime on drops and timeouts too`	1/0/0	`eth/downloader` (1)	3/0	`eth/downloader/statesync.go` (6)
⚠️	#21428	`ethstats: overwrite old errors`	1/0/0	`ethstats` (1)	2/3	`ethstats/ethstats.go` (10)
✅	#21433	`eth/downloader: allow all timers to exit`	1/0/0	`eth/downloader` (1)	1/7	`eth/downloader/statesync.go` (16)
⚠️	#21434	`ethstats: split read and write lock, otherwise they'll lock up`	1/0/0	`ethstats` (1)	18/14	`ethstats/ethstats.go` (64)
✅	#21435	`tests: add Berlin-definition identical to YOLOv1`	1/0/0	`tests` (1)	14/0	`tests/init.go` (28)
⚠️	#21437	`params: update CHTs for v1.9.19`	1/0/0	`params` (1)	16/16	`params/config.go` (64)

120 Changed files

🔍	File	Lines Changed	Linked PR
✅	`les/fetcher.go`	2410	#20692
‼️	`node/node.go`	1680
⚠️	`node/node_test.go`	1532
✅	`node/rpcstack.go`	730
✅	`node/api_test.go`	700
✅	`eth/fetcher/block_fetcher_test.go`	592	#20692
✅	`p2p/testing/protocoltester.go`	568
✅	`p2p/testing/protocolsession.go`	566
✅	`les/fetcher_test.go`	536	#21382 #20692
⚠️	`ethstats/ethstats.go`	442	#21404 #21105 #21434 #21428
✅	`eth/fetcher/block_fetcher.go`	412	#20692
‼️	`node/api.go`	358
‼️	`cmd/utils/flags.go`	262	#20391 #21105 #21416
✅	`node/utils_test.go`	256
‼️	`node/service.go`	244
⚠️	`eth/downloader/downloader_test.go`	240	#21378 #21383
✅	`node/rpcstack_test.go`	232
‼️	`graphql/graphql_test.go`	216	#21105
✅	`les/peer.go`	206	#20692 #21426
✅	`node/service_test.go`	196
‼️	`eth/backend.go`	188	#20391 #21105
✅	`p2p/simulations/adapters/inproc.go`	188
✅	`signer/core/signed_data_internal_test.go`	188	#21307
✅	`p2p/simulations/adapters/exec.go`	180
✅	`miner/stress_ethash.go`	178	#21105
‼️	`miner/worker.go`	176	#21044
✅	`miner/stress_clique.go`	174	#21105
✅	`whisper/whisperv6/whisper_test.go`	172
✅	`graphql/service.go`	170	#21105
✅	`p2p/nat/natupnp.go`	160	#21390
✅	`les/utils/expiredvalue_test.go`	154	#20692
✅	`p2p/testing/peerpool.go`	134
✅	`core/bloombits/matcher.go`	118	#20878
‼️	`les/client.go`	114	#21105 #20692
✅	`whisper/whisperv6/whisper.go`	112
✅	`les/server.go`	112	#21105 #20692 #21426
⚠️	`core/types/transaction.go`	110	#21358
⚠️	`core/types/transaction_test.go`	106	#21358
⚠️	`trie/database.go`	102	#20391
‼️	`cmd/geth/main.go`	102	#20391 #21105
✅	`les/utils/expiredvalue.go`	88	#20692
✅	`p2p/simulations/adapters/types.go`	86
✅	`node/node_example_test.go`	78
‼️	`rpc/http.go`	74	#21392
✅	`node/doc.go`	74
⚠️	`rpc/client_test.go`	74	#21392
‼️	`core/blockchain.go`	70	#21095 #20391
✅	`signer/core/signed_data.go`	66	#21306 #21307
⚠️	`params/config.go`	64	#21437
⚠️	`consensus/clique/clique.go`	62	#21044 #20692
✅	`node/lifecycle.go`	62
⚠️	`consensus/consensus.go`	60	#20692
✅	`eth/downloader/statesync.go`	60	#21429 #21433 #21427
⚠️	`ethclient/ethclient_test.go`	58	#21105
✅	`mobile/geth.go`	58	#21105
‼️	`eth/config.go`	56	#20391 #21416
✅	`les/client_handler.go`	56	#20692
✅	`p2p/simulations/network_test.go`	56
⚠️	`les/server_handler.go`	54	#20692 #21426
✅	`les/commons.go`	52	#21105
✅	`whisper/mailserver/server_test.go`	50
⚠️	`cmd/faucet/faucet.go`	50	#21105
‼️	`eth/api_backend.go`	44	#21105
‼️	`core/rawdb/freezer.go`	44	#21384 #21105
✅	`les/api_test.go`	42	#21105
✅	`whisper/whisperv6/filter_test.go`	42
⚠️	`eth/downloader/peer.go`	42	#21378
⚠️	`node/config.go`	40
‼️	`cmd/geth/chaincmd.go`	40	#21414 #21415 #21105
‼️	`consensus/ethash/consensus.go`	40	#20692
✅	`cmd/devp2p/enrcmd.go`	38	#21270
✅	`les/checkpointoracle/oracle.go`	36	#21105 #21425
⚠️	`cmd/geth/retesteth.go`	36	#20692
✅	`p2p/simulations/examples/ping-pong.go`	34
⚠️	`cmd/geth/consolecmd.go`	32	#21105
‼️	`node/endpoints.go`	30
⚠️	`rpc/client.go`	30	#21392
‼️	`cmd/geth/config.go`	28	#21415 #21105
✅	`tests/init.go`	28	#21435
✅	`cmd/utils/flags_legacy.go`	26	#21105
✅	`p2p/simulations/network.go`	24
⚠️	`eth/gen_config.go`	24	#20391
✅	`node/errors.go`	22
✅	`rpc/subscription.go`	18	#21391
✅	`p2p/nat/nat.go`	18	#21390
‼️	`les/api_backend.go`	18	#21105
✅	`p2p/simulations/http_test.go`	18
✅	`console/console_test.go`	16	#21105
✅	`signer/core/signed_data_test.go`	16	#21306
‼️	`internal/ethapi/backend.go`	14	#21105
⚠️	`core/tx_pool.go`	14	#21159
✅	`core/vm/contract.go`	12	#21411
‼️	`core/state/database.go`	12	#20391
⚠️	`cmd/geth/usage.go`	12	#20391 #21105
✅	`les/clientpool.go`	12	#20692
⚠️	`build/ci.go`	12	#21374
✅	`signer/storage/aes_gcm_storage.go`	12	#21379
✅	`cmd/wnode/main.go`	10	#21105
⚠️	`les/odr_test.go`	8	#20692
⚠️	`eth/downloader/downloader.go`	8	#21378
✅	`light/postprocess.go`	8	#20391
✅	`p2p/simulations/connect_test.go`	8
‼️	`eth/api_tracer.go`	8	#20391
⚠️	`cmd/geth/dao_test.go`	6	#21105
✅	`whisper/whisperv6/api_test.go`	6
⚠️	`consensus/clique/api.go`	4	#20692
⚠️	`eth/handler.go`	4	#20692
⚠️	`params/version.go`	4
✅	`cmd/utils/cmd.go`	4	#21105
✅	`p2p/simulations/test.go`	4
✅	`consensus/ethash/sealer.go`	4	#20692
✅	`cmd/p2psim/main.go`	4	#21105
⚠️	`core/genesis.go`	4	#20391
✅	`cmd/clef/docs/setup.md`	4	#21379
✅	`cmd/faucet/faucet.html`	4	#21379
⚠️	`consensus/ethash/ethash.go`	4	#20692
⚠️	`eth/peer.go`	4	#21419
✅	`node/defaults.go`	2
⚠️	`les/test_helper.go`	2	#20692
✅	````	0	#20692

* cmd, core, eth, light, trie: dump clean cache periodically * eth: update config * trie: minor fix * core, trie: address comments * eth: remove useless * trie: print clean cache dump start too Co-authored-by: Péter Szilágyi <peterke@gmail.com>

* cmd, consensus, eth, les: implement light fetcher * les: address comment * les: address comment * les: address comments * les: check td after delivery * les: add linearExpiredValue for error counter * les: fix import * les: fix dead lock * les: order announces by td * les: encapsulate invalid counter * les: address comment * les: add more checks during the delivery * les: fix log * eth, les: fix lint * eth/fetcher: address comment

This reduces complexity of some lengthy functions in worker.go, making the code easier to read.

* init notes removed some mentions of eth62, bumped protocol err too old to >=63 * remove sanity checks and bump supported protocol version up to 63 * remove 62 tests, still need to add 65 * remove 65 tests

* Disable symbol table and DWARF generation by default. Trimpath if compiling with Go >= 1.13 * Set Go to minimum version 1.13. Revert debug symbol changes.

This replaces the two-stage shutdown scheme with the one we use almost everywhere else: a single quit channel signalling termination. Co-authored-by: Felix Lange <fjl@twurst.com>

core: sort txs at the same gas price by received time

@protolambda

…391) Found by @protolambda

Resolves #20163 Co-authored-by: Felix Lange <fjl@twurst.com>

…a ChainId (#21306) * Do not check for a non-nil ChainId * Add encoding test

This PR significantly changes the APIs for instantiating Ethereum nodes in a Go program. The new APIs are not backwards-compatible, but we feel that this is made up for by the much simpler way of registering services on node.Node. You can find more information and rationale in the design document: https://gist.github.com/renaynay/5bec2de19fde66f4d04c535fd24f0775. There is also a new feature in Node's Go API: it is now possible to register arbitrary handlers on the user-facing HTTP server. In geth, this facility is used to enable GraphQL. There is a single minor change relevant for geth users in this PR: The GraphQL API is no longer available separately from the JSON-RPC HTTP server. If you want GraphQL, you need to enable it using the ./geth --http --graphql flag combination. The --graphql.port and --graphql.addr flags are no longer available.

…padding (#21307) * Handle hex strings for bytesX types * Add tests for parseBytes * Improve tests * Return nil bytes if error is non-nil * Right-pad instead of left-pad bytes * More tests

Co-authored-by: Felix Lange <fjl@twurst.com>

* core: avoid modification of accountSet cache in tx_pool when runReorg, we may copy the dirtyAccounts' accountSet cache to promoteAddrs in which accounts will be promoted, however, if we have reset request at the same time, we may reuse promoteAddrs and modify the cache content which is against the original intention of accountSet cache. So, we need to make a new slice here to avoid modify accountSet cache. * core: fix flatten condition + comment Co-authored-by: Felix Lange <fjl@twurst.com>

Fixes #21403

This adds a lock around requests because some routers can't handle concurrent requests. Requests are also rate-limited. The Map function request a new mapping exactly when the map timeout occurs instead of 5 minutes earlier. This should prevent duplicate mappings.

* eth65 tests linted * remove non-latest eth light tests

…1414) * should fix import / export issues related to DB unavailability * document reason for makeConfigNode * fix comment * comment consistency * remove comments * lint

core/vm: avoid map lookups for accessing jumpdest analysis

* chaincmd should make config nodes instead of full nodes * add documentation for using makeConfigNode instead of makeFullNode; * add documentation to functions * code style

…unced (#21419)

* cmd/utils: grant snapshot cache to trie if disabled * eth: fix up default non-mainnet cache distribution

ricardolyn · 2021-03-08T16:12:56Z

Dependency on Consensys/quorum-acceptance-tests#83

node/node.go

cmd/geth/main.go

extension/backend.go

ricardolyn · 2021-03-09T16:47:43Z

miner/worker.go

-		privateReceipts[i] = new(types.Receipt)
-		*privateReceipts[i] = *l
-	}
+	privateReceipts := copyReceipts(w.current.privateReceipts) // Quorum


why do they need the privateReceipts to seal the block?

node/node.go

node/rpcstack.go

permission/backend.go

plugin/service.go

nmvalera

LGTM

nmvalera

LGTM

karalabe and others added 30 commits July 27, 2020 14:58

params: begin v1.9.19 release cycle

8e7bee9

signer/storage: fix a badly ordered error check (#21379)

79ce553

core: sort txs at the same gas price by received time

c47052a

core: API-less transaction time sorting

298a19b

miner: refactor helper functions in worker.go (#21044)

37564ce

This reduces complexity of some lengthy functions in worker.go, making the code easier to read.

les: fix unittest (#21382)

350a049

eth/downloader: remove eth62 (#21378)

1976bb3

* init notes removed some mentions of eth62, bumped protocol err too old to >=63 * remove sanity checks and bump supported protocol version up to 63 * remove 62 tests, still need to add 65 * remove 65 tests

build: use -trimpath flag when building executables (#21374)

abf2d7d

* Disable symbol table and DWARF generation by default. Trimpath if compiling with Go >= 1.13 * Set Go to minimum version 1.13. Revert debug symbol changes.

core/bloombits: use single channel for shutdown (#20878)

9e04c5e

This replaces the two-stage shutdown scheme with the one we use almost everywhere else: a single quit channel signalling termination. Co-authored-by: Felix Lange <fjl@twurst.com>

core/rawdb: convert some comments to godoc convention (#21384)

ff90894

Merge pull request #21358 from hendrikhofstadt/fix/tx-sort-time

a00dc50

core: sort txs at the same gas price by received time

rpc: remove silly use of ReadVarint in subscription ID generator (#21…

9c2ac6f

…391) Found by @protolambda

rpc: add SetHeader method to Client (#21392)

290d6bd

Resolves #20163 Co-authored-by: Felix Lange <fjl@twurst.com>

signer/core: EIP-712 encoded data should not reject a Domain without …

b2b14e6

…a ChainId (#21306) * Do not check for a non-nil ChainId * Add encoding test

signer: EIP 712, parse bytes and bytesX as hex strings + correct …

90dedea

…padding (#21307) * Handle hex strings for bytesX types * Add tests for parseBytes * Improve tests * Return nil bytes if error is non-nil * Right-pad instead of left-pad bytes * More tests

cmd/devp2p: print enode:// URL in enrdump (#21270)

e24e05d

Co-authored-by: Felix Lange <fjl@twurst.com>

ethstats: avoid concurrent write on websocket (#21404)

82a9e11

Fixes #21403

core/vm: avoid map lookups for accessing jumpdest analysis

8ead45c

core: use errors.Is for consensus errors check (#21095)

5a88a7c

downloader: add eth65 tests (#21383)

2de37f2

* eth65 tests linted * remove non-latest eth light tests

cmd/geth: fix import / export issues related to DB unavailability (#2…

4a04127

…1414) * should fix import / export issues related to DB unavailability * document reason for makeConfigNode * fix comment * comment consistency * remove comments * lint

Merge pull request #21411 from holiman/fix_codelookup

4fde0ca

core/vm: avoid map lookups for accessing jumpdest analysis

cmd/geth: fixes db unavailability for chain commands (#21415)

d21303f

* chaincmd should make config nodes instead of full nodes * add documentation for using makeConfigNode instead of makeFullNode; * add documentation to functions * code style

eth: use maxQueuedTxAnns for to limit the number of transactions anno…

5d4512b

…unced (#21419)

cmd/utils: grant snapshot cache to trie if disabled (#21416)

68754f3

* cmd/utils: grant snapshot cache to trie if disabled * eth: fix up default non-mainnet cache distribution

ricardolyn added 3 commits March 8, 2021 15:59

fix: add missing code to get contract auth provider function from LES

a7c8c6b

fix: lint issues

f7ff6cb

tidy: remove todos

041aafa

ricardolyn commented Mar 8, 2021

View reviewed changes

node/node.go Show resolved Hide resolved

ricardolyn added 2 commits March 8, 2021 19:44

tidy: tidy up comments

51e0e0c

fix: lint issues

e5fbf36

ricardolyn requested a review from nmvalera March 9, 2021 09:53

ricardolyn marked this pull request as ready for review March 9, 2021 09:53